sentry: Enable tracing feature
#3919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
Turbo87
force-pushed
the
sentry-tracing
branch
2 times, most recently
from
b1b6843 to
db6a254
Compare
|
☔ The latest upstream changes (presumably #3920) made this pull request unmergeable. Please resolve the merge conflicts. |
Turbo87
force-pushed
the
sentry-tracing
branch
from
db6a254 to
0130a5a
Compare
JohnTitor
approved these changes
Sep 21, 2021
Turbo87
force-pushed
the
sentry-tracing
branch
2 times, most recently
from
18a73bc to
344c753
Compare
|
☔ The latest upstream changes (presumably #3965) made this pull request unmergeable. Please resolve the merge conflicts. |
Turbo87
force-pushed
the
sentry-tracing
branch
from
344c753 to
f85aac6
Compare
|
@pietroalbini @jtgeibel any objections on this? |
Turbo87
force-pushed
the
sentry-tracing
branch
from
f85aac6 to
422c1a2
Compare
|
apparently not... 😅 @bors r=JohnTitor |
|
📌 Commit 422c1a2 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 5, 2021
sentry: Enable `tracing` feature https://github.com/tokio-rs/tracing/releases/tag/tracing-subscriber-0.2.21 enables us to use per-layer event filters, which previously blocked us from using the `tracing` feature of `sentry`. This PR enables the feature using the default configuration, which reports all `error!()` usages as errors and `warn!()` and `info!()` as breadcrumbs for associated errors.
|
💥 Test timed out |
Turbo87
force-pushed
the
sentry-tracing
branch
from
422c1a2 to
b2bb38f
Compare
|
let's try this again after rebasing... @bors r=JohnTitor |
|
📌 Commit b2bb38f has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/tokio-rs/tracing/releases/tag/tracing-subscriber-0.2.21 enables us to use per-layer event filters, which previously blocked us from using the
tracingfeature ofsentry. This PR enables the feature using the default configuration, which reports allerror!()usages as errors andwarn!()andinfo!()as breadcrumbs for associated errors.